Skip to content

solution#2199

Open
jk-npc wants to merge 2 commits intomate-academy:masterfrom
jk-npc:develop
Open

solution#2199
jk-npc wants to merge 2 commits intomate-academy:masterfrom
jk-npc:develop

Conversation

@jk-npc
Copy link

@jk-npc jk-npc commented Mar 5, 2026

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am requesting changes because a critical issue is preventing your script from running. While your calculation and formatting logic is well-written, the way you select elements from the DOM causes a runtime error.

You're using document.querySelector('.population'), which only returns the very first matching element. The code then attempts to iterate over this single element as if it were a list, which results in a TypeError and stops the script from executing any further.

To fix this, you need to use a method that returns all matching elements. Please look into document.querySelectorAll(), which will provide a collection that you can loop through. Once you make this adjustment, the rest of your excellent logic should work as intended!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

'use strict';

// write your code here
const populations = document.querySelector('.population');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The document.querySelector() method returns only the first element that matches the specified selector. To retrieve all elements with the class population, you need to use a method that returns a collection of elements, like document.querySelectorAll().

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this pull request! I'm happy to approve your solution. You've successfully addressed the feedback from the previous review by using document.querySelectorAll to correctly gather all the population data. Your code now perfectly calculates the average and total values and updates the display as required. All requirements have been met. Great job!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants