Skip to content
Open

fdsfsd #2477

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"license": "GPL-3.0",
"devDependencies": {
"@mate-academy/eslint-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^2.1.3",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^28.6.0",
"eslint-plugin-node": "^11.1.0",
Expand Down
26 changes: 24 additions & 2 deletions src/arrayMethodSort.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,30 @@
* Implement method Sort
*/
function applyCustomSort() {
[].__proto__.sort2 = function(compareFunction) {
// write code here
[].__proto__.sort2 = function (compareFunction) {
let cmp;

if (typeof compareFunction === 'function') {
cmp = (a, b) => compareFunction(a, b);
} else {
cmp = (a, b) =>
String(a) > String(b) ? 1 : String(a) < String(b) ? -1 : 0;
}

for (let i = 0; i < this.length; i++) {
let b = 0;

for (let j = i; j < this.length; j++) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This inner loop starts by comparing an element with itself (j starts at i). To make the code slightly more efficient, you can start the loop from j = i + 1.

if (cmp(this[i], this[j]) > 0) {
b = this[i];
this[i] = this[j];
this[j] = b;
b = 0;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line reassigning b to 0 is not necessary. The variable b will be correctly reassigned the next time a swap happens, or it will be re-initialized at the beginning of the next outer loop iteration.

}
}
}

return this;
};
}

Expand Down