Skip to content

An alert for componentWillReceiveProps method. #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

An alert for componentWillReceiveProps method. #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3b6100c
ci(travis-ci): add semantic-release to streamline releasing
david-at-frog Oct 11, 2019
710be32
fix: silence depcrecated componentWillReceiveProps warnings
david-at-frog Oct 11, 2019
7b28437
Specify package files
sonicdoe Mar 28, 2019
68d9148
fix(npm): import 'specify package files' commit
david-at-frog Oct 11, 2019
b0786e1
docs(package.json): update author to frog education
david-at-frog Oct 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
language: node_js
node_js:
- lts/*
- 10.16.3

jobs:
include:
- stage: release
node_js: lts/*
deploy:
provider: script
skip_cleanup: true
script:
- npx semantic-release
2 changes: 1 addition & 1 deletion ActionButton.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default class ActionButton extends Component {
clearTimeout(this.timeout);
}

componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps(nextProps) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be the only change necessary?

if (nextProps.resetToken !== this.state.resetToken) {
if (nextProps.active === false && this.state.active === true) {
if (this.props.onReset) this.props.onReset();
Expand Down
Loading