Handle rolling std window<2 without runtime warnings#69
Open
shuofengzhang wants to merge 1 commit intomassive-com:masterfrom
Open
Handle rolling std window<2 without runtime warnings#69shuofengzhang wants to merge 1 commit intomassive-com:masterfrom
shuofengzhang wants to merge 1 commit intomassive-com:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
window < 2guard in_rolling_stdto return an all-NaNresult immediately._rolling_stddocstring to clarify the sample-std (ddof=1) behavior for undersized windows.test_window_1_returns_nanto assert the undefinedwindow=1case returns allNaNvalues.Why
ddof=1is undefined for window sizes below 2.np.std(..., ddof=1)forwindow=1, which emitted runtime warnings during tests.Testing
scripts/clone_and_test.sh massive-com/mcp_massive(583 passed)