[X-2105] Support right behaviour when we have alias or other normalize operation for view matcher#28
Open
zhuqi-lucas wants to merge 4 commits intobranch-51from
Open
[X-2105] Support right behaviour when we have alias or other normalize operation for view matcher#28zhuqi-lucas wants to merge 4 commits intobranch-51from
zhuqi-lucas wants to merge 4 commits intobranch-51from
Conversation
…on for view matcher
There was a problem hiding this comment.
Pull request overview
This PR fixes a normalization bug in residual predicate subsumption to correctly compare normalized residual filter sets, and adds regression tests covering boolean predicate normalization, equivalence-class residual normalization, and alias-based filter rewrites.
Changes:
- Fix residual set difference to use the normalized
other_residualsset during subsumption checks. - Add regression tests for boolean predicate equivalences (
NOT colvscol = false,colvscol = true). - Add regression tests for residual normalization across equivalence classes and for equality/range filters on aliased projection columns.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
xudong963
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.