Make semcode work well with gemini #3
+73
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgushchin
changed the title
masoncl
reviewed
Dec 18, 2025
Cargo.toml
Outdated
| arrow-array = "56.2" | ||
| arrow-schema = "56.2" | ||
| home = "=0.5.11" | ||
| lancedb = { version = "0.21", default-features = false } |
Owner
There was a problem hiding this comment.
The later versions of lancedb had improved performance. Is it possible to get lancedb 0.22 and arrow 56.x with the old rust?
Never dump initialization errors to stdout, as it breaks the mcp protocol and sometimes confuses a LLM. Signed-off-by: Roman Gushchin <[email protected]>
Using println! interferes with the JSON-RPC protocol on stdout. This change replaces it with tracing macros which can be directed to stderr or a file, preserving the integrity of the communication channel. Signed-off-by: Roman Gushchin <[email protected]>
Adds a 'ping' tool for clients to check server liveness. Improves JSON-RPC handling to distinguish between requests (expecting response) and notifications (no response), preventing protocol errors with strict clients. Signed-off-by: Roman Gushchin <[email protected]>
Moving create_tables to the background task prevents blocking the main thread during startup, allowing the MCP server to respond to the initial handshake immediately. This significantly improves perceived performance and connectivity with clients that have short timeouts. Signed-off-by: Roman Gushchin <[email protected]>
rgushchin
force-pushed
the
build_fixes.1
branch
from
a4eb8da to
9e25d0f
Compare
Author
|
@masoncl Got it. I managed to build it with some local changes to lancedb, which is good enough for now. I dropped this change. The rest is required for making gemini work well with semcode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gemini CLI is more sensitive than Claude to bogus output and startup latency. It makes it often fail at the initialization stage. Fix this by cleaning up the output code and refactoring the initialization sequence.