Fixed Content-Length deletion for reverse proxies in Martini#17
Open
Romanowiczmarek wants to merge 2 commits intomartini-contrib:masterfrom
Open
Fixed Content-Length deletion for reverse proxies in Martini#17Romanowiczmarek wants to merge 2 commits intomartini-contrib:masterfrom
Romanowiczmarek wants to merge 2 commits intomartini-contrib:masterfrom
Conversation
It turns out that deleting Content-Length header field at the end of serveGzip function may not be enough for gzip. According to the spec of compress/gzip, a Write() call may flush the writer before closing it. This means that in certain cases, gzip writer flushes compressed data to the underlying martini.ResponseWriter with a wrong header Content-Length field, i.e before it is deleted by serveGzip resulting in a "Conn.Write wrote more than the declared Content-Length" error. This change adds a defensive measure of deleting Content-Length before a potential write.
| } | ||
|
|
||
| // removing content length before writing in case gzip.Writer writes to the | ||
| // underlying http.ResponseWriter before closing. See notes in compress/gzip. |
Author
There was a problem hiding this comment.
Here is the link to compress/gzip.
Extracted comment:
Write writes a compressed form of p to the underlying io.Writer. The compressed bytes are not necessarily flushed until the Writer is closed.
In some cases, WriteHeader() can be called explicitly by the user which may result in the Content-Length field of a header to be written to the underlying ResponseWriter. This CL adds one more defensive removal of Content-Length for the reverse proxy issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that deleting Content-Length header field at the end of
serveGzip function may not be enough for gzip. According to the spec
of compress/gzip, a Write() call may flush the writer before closing
it. This means that in certain cases, gzip writer flushes compressed
data to the underlying martini.ResponseWriter with a wrong header
Content-Length field, i.e before it is deleted by serveGzip resulting
in a "Conn.Write wrote more than the declared Content-Length" error.
This change adds a defensive measure of deleting Content-Length
before a potential write.