Add edit and delete options for Time Entries#5
Open
martin-rifon wants to merge 2 commits into
Open
Conversation
diegomura
reviewed
Dec 16, 2016
diegomura
left a comment
diegomura
left a comment
There was a problem hiding this comment.
Esta muy bien!
Los comentarios son de estilos mas que nada.
Se nota que le agarraste la mano 😄
| const { showModal } = this.state; | ||
| const toggleShowModal = ::this.toggleShowModal | ||
| const deleteTimeEntry = ::this.deleteTimeEntry | ||
| const onChange = (dateString, attribute) => { |
There was a problem hiding this comment.
Porque definir esto como una const y no un method de la class?
|
|
||
| 'ALTER_TIME_ENTRY': (state, action) => { | ||
| const timeEntry = action.timeEntry; | ||
| const timeEntryIndex = state.timeEntries |
There was a problem hiding this comment.
Indentacion muy rara. que tal:
const timeEntryIndex = state.timeEntries.findIndex((elem) => (
elem.id == timeEntry.id
));
Owner
Author
|
Diego, fueron los cambios. Te comento que ahora me voy a tomar una pausa con esto. Cuando vuelva, pienso ver primero el tema de agregarle testing y después corregir algunos bugs que vi. Cuando todo eso este, voy a seguir con las features extendidas de la wiki. Me gustaría eventualmente dejar este proyectito con todas las features y el código bien prolijo. Muchas gracias de nuevo por tu feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@diegomura
Bueno Diego, te dejo una primera version de lo que seria edit y delete de las Time Entries. Tiene bugs y el codigo se puede emprolijar, pero quise pushear ahora por si no me daba el tiempo de terminarlo. Cualquier cosa, con los cambios que hay aca seria la entrega del proyecto, pero espero tener algunos minutos para poder subir algun cambio mas.
Saludos!