perf(encode): vec alloc & utf8 unchecked#180
Open
AaronO wants to merge 2 commits intomarshallpierce:masterfrom
Open
perf(encode): vec alloc & utf8 unchecked#180AaronO wants to merge 2 commits intomarshallpierce:masterfrom
AaronO wants to merge 2 commits intomarshallpierce:masterfrom
Conversation
Improves throughput by 10-20% We avoid zeroing the allocated vec since we'll write into it and we don't need to check utf8 when building the String since all alphabets emit ascii/utf8
jonasbb
reviewed
Mar 11, 2022
| let mut buf = vec![0; encoded_size]; | ||
| let mut buf = Vec::with_capacity(encoded_size); | ||
| unsafe { | ||
| buf.set_len(encoded_size); |
There was a problem hiding this comment.
The safety documentation of set_len is pretty clear that this is UB. Namely it states
The elements at
old_len..new_lenmust be initialized.
I think it might be safe to call after encode_with_padding. If you need uninitialized memory you probably want to use MaybeUninit.
This was referenced Feb 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves throughput by 10-20%
We avoid zeroing the allocated vec since we'll write into it and we don't need to check utf8 when building the String since all alphabets emit ascii/utf8
Benches