Added lifetime parameters to all the writing systems#146
Open
sapient-cogbag wants to merge 1 commit intomarshallpierce:masterfrom
Open
Added lifetime parameters to all the writing systems#146sapient-cogbag wants to merge 1 commit intomarshallpierce:masterfrom
sapient-cogbag wants to merge 1 commit intomarshallpierce:masterfrom
Conversation
…can write to arbitrary string refs and such - also bumped version (do not think this is a breaking change? all the tests compiled. nyaa
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
==========================================
- Coverage 94.95% 94.49% -0.47%
==========================================
Files 15 15
Lines 1783 1797 +14
==========================================
+ Hits 1693 1698 +5
- Misses 90 99 +9
Continue to review full report at Codecov.
|
Owner
|
Thanks; I will look into this as soon as I can. |
Owner
|
Can you help me understand the use case for this? Since Write is implemented for &mut Write, why do we need to add lifetimes to make it reference-friendly? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think this is a breaking change as far as I am aware.