chore(global): upgrade flutter version and deps#108
Conversation
📝 WalkthroughWalkthroughUpdated Flutter SDK to version 3.41.0-stable and raised the minimum macOS deployment target from 10.14 to 10.15 across the iOS project configuration, Podfile, and build settings. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.tool-versions:
- Line 1: CI workflows and README still pin Flutter to "3.35.5" while
.tool-versions uses "3.41.0-stable"; search for the string "3.35.5" in the
workflow files (windows_build.yaml, web_build.yaml, validate.yaml,
debian_build.yaml, appimage_build.yaml) and update those pins to
"3.41.0-stable", and also update the README's stated Flutter requirement to
"3.41.0-stable" so all CI and docs match .tool-versions.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
apps/flites/macos/Podfile.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
.tool-versionsapps/flites/macos/Podfileapps/flites/macos/Runner.xcodeproj/project.pbxproj
| @@ -1 +1 @@ | |||
| flutter 3.35.5-stable No newline at end of file | |||
| flutter 3.41.0-stable No newline at end of file | |||
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== .tool-versions =="
cat .tool-versions
echo
echo "== Flutter version pins in CI/workflows =="
fd -HI -t f '.*\.(yml|yaml)$' .github/workflows 2>/dev/null \
| xargs -r rg -nP 'flutter(-version)?\s*:|subosito/flutter-action|fvm|[0-9]+\.[0-9]+\.[0-9]+(-stable)?'
echo
echo "== FVM-related config/version pins (if any) =="
fd -HI -t f 'fvm_config\.json|\.fvmrc|pubspec\.yaml|README\.md' \
| xargs -r rg -nP 'flutter|fvm|[0-9]+\.[0-9]+\.[0-9]+(-stable)?'Repository: marqably/flites
Length of output: 4075
Update Flutter version pins in all CI workflows to match .tool-versions.
CI workflows are pinned to 3.35.5, but .tool-versions specifies 3.41.0-stable. This divergence will cause local builds (via FVM/asdf) to use version 3.41.0-stable while CI pipelines run 3.35.5, creating inconsistent build environments.
Update required in:
.github/workflows/windows_build.yaml(line 66).github/workflows/web_build.yaml(line 60).github/workflows/validate.yaml(line 21).github/workflows/debian_build.yaml(line 62).github/workflows/appimage_build.yaml(line 55)README.md(line 61, update version requirement)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.tool-versions at line 1, CI workflows and README still pin Flutter to
"3.35.5" while .tool-versions uses "3.41.0-stable"; search for the string
"3.35.5" in the workflow files (windows_build.yaml, web_build.yaml,
validate.yaml, debian_build.yaml, appimage_build.yaml) and update those pins to
"3.41.0-stable", and also update the README's stated Flutter requirement to
"3.41.0-stable" so all CI and docs match .tool-versions.
|
LGTM. But we should update the flutter version also in the build files. Coderabbit mentioned it above |
Description
Upgrade flutter to newest version, commit updated dependencies.
Type of Change
Summary by CodeRabbit