Add offline support to <ReferenceInputBase>, <ReferenceInput> and <AutocompleteInput>
#10864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madeorsk
requested changes
Aug 7, 2025
| @@ -340,6 +341,27 @@ const UserCountry = () => { | |||
| } | |||
| ``` | |||
|
|
|||
| ## `offline` | |||
There was a problem hiding this comment.
We should document this in AutocompleteArrayInput too, as it's inheriting this property.
| ({ | ||
| sort: currentSort, | ||
| allChoices: finalData, | ||
| availableChoices: possibleValuesData, |
There was a problem hiding this comment.
You removed the default value of possibleValuesData, it can now be undefined / null. Not sure that it's a problem but to ensure retrocompatiblity:
Suggested change
| availableChoices: possibleValuesData, | |
| availableChoices: possibleValuesData ?? [], |
Madeorsk
force-pushed
the
offline-support-reference-one-field
branch
from
2f737ed to
29c4c07
Compare
… `<AutocompleteInput>`
Madeorsk
force-pushed
the
offline-support-reference-input
branch
from
494b79c to
d26a330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Our components and hooks can't leverage the offline support provided by Tanstack Query.
Solution
ra-ui-materialuiHow To Test
<ReferenceInputBase><ReferenceInput>&<AutocompleteInput>(Simulate offline before trying to filter choices to test the<AutocompleteInput>)Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a featureAlso, please make sure to read the contributing guidelines.