test(examples): verify signed manifest example#40
Merged
marmar9615-cloud merged 1 commit intomainfrom Apr 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds verifier-backed checks for the signed-manifest example without adding CLI/scanner/MCP enforcement.
examples/signed-manifest-basic/agentbridge-keys.jsonwith the public Ed25519 JWK matching the example signer.npm run validate:examplesto validate the key set, verify the generated signed manifest withverifyManifestSignature(), assert tamper failure withsignature-invalid, and confirm an unsigned copy still schema-validates.--require-signature/ scanner checks / MCP enforcement are follow-ups.Context
signManifest/createSignedManifesthelpers.verifyManifestSignature()and test vectors.Parallel safety
This PR stays out of scanner implementation, core implementation, core tests, spec files, and MCP runtime files. It only consumes the verifier from examples/CLI tests and docs.
Files added
examples/signed-manifest-basic/agentbridge-keys.jsonFiles modified
CHANGELOG.mdexamples/README.mdexamples/signed-manifest-basic/README.mdpackages/cli/README.mdpackages/cli/src/tests/signed-examples-regression.test.tsscripts/validate-examples.mjsVerifier-backed checks added
agentbridge validate.validateKeySet().verifyManifestSignature()using fixednowandexpectedIssuer.signature-invalid.Validation
npx vitest run packages/cli/src/tests/signed-examples-regression.test.ts— passed, 1 file / 2 testsnpx vitest run packages/cli/src/tests— passed, 4 files / 34 testsnpm run typecheck:clean— passednpm test— passed, 24 files / 386 testsnpm run build— passednpm run pack:dry-run— passed, all packages OKnpm run validate:examples— passed, including verifier-backed signed example pathnpm run validate:mcp-config-examples— passednpx tsx examples/signed-manifest-basic/manifest.ts > /tmp/signed-basic.agentbridge.json— passednode packages/cli/dist/bin.js validate /tmp/signed-basic.agentbridge.json— passedverifyManifestSignature()— passed; tampered manifest returnedsignature-invalidBrowser / UI status
No UI, demo-app, or Studio surface changed. CLI/example/core-verifier command-level smoke is the relevant test surface, so browser/computer-use/Playwright was not needed.
Safety confirmations
--require-signature, or MCP enforcement implemented.