Nh3CharField and Nh3TextField #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marksweb This should be ready for review. 😄 |
…ate the old naming
for more information, see https://pre-commit.ci
blag
force-pushed
the
nh3charfield-and-nh3textfield
branch
from
c62591f to
1759650
Compare
|
@blag I'm conscious that I don't get enough time for this, but keen to get this merged. Do you think it's possible to get a test to detect the warning so that can maintain 100% coverage? |
|
Added the test like you asked. Coverage should be 100% now. Thanks for creating this project; really appreciate your effort. |
marksweb
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added on to #44, incorporating the feedback from that PR.
Additionally, since
Nh3CharFieldandNh3TextFieldended up looking so similar, I just moved their logic into a mixin and tweaked their inheritance. This should also help anybody who is trying to write a custom field with Nh3, since they can now base theirs onNh3FieldMixin.Tests got a lot more complicated, and they would not allow two different models in different test modules (
test_models_charfield.pyandtest_models_textfield.py) to be called the same thing. To ensure this wouldn't happen again I moved the test models and forms into their own respective modules.Closes #44.
Resolves #45.