perf(runtime-tags): skip serializing unused controllable <let> change handler#3293
perf(runtime-tags): skip serializing unused controllable <let> change handler#3293DylanPiercey wants to merge 1 commit into
<let> change handler#3293Conversation
🦋 Changeset detectedLatest commit: a731a01 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Review limit reached
More reviews will be available in 50 minutes and 26 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (8)
📒 Files selected for processing (5)
WalkthroughThe PR changes runtime-tags so controllable 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3293 +/- ##
=======================================
Coverage 94.25% 94.25%
=======================================
Files 383 383
Lines 50869 50894 +25
Branches 3855 3859 +4
=======================================
+ Hits 47946 47971 +25
Misses 2897 2897
Partials 26 26 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ge handler A controllable `<let>`'s `valueChange` handler is only read back on resume (`_let_change`) when the variable is actually reassigned on the client; reactive `value=` updates run in rendering mode and re-set the handler from the fresh arg. The `TagVariableChange` accessor is now serialized only when the binding has assignment sites, resolved in `finalizeReferences` over the marked bindings (so it still applies when the value was pruned). No behavior change.
0048472 to
a731a01
Compare
A controllable
<let>'svalueChangehandler (TagVariableChange:<binding>) is only read back on resume by_let_change, and only when the variable is actually reassigned on the client. Reactivevalue=updates run in rendering mode and re-set the handler from the fresh argument, so they don't depend on the serialized copy — only a direct assignment (the signal's entry point) does.The handler is now serialized only when the binding has assignment sites. The decision is made in
finalizeReferencesover the marked controllable-<let>bindings (rather than the post-prunebindingsset), so it still applies when the<let>'s value was pruned but it's still assigned + has a change handler.No behavior change: only
writes.*.html/html.bundle.*/sizes.jsonsnapshots changed — norender/dom.bundlediffs. Two fixtures with a never-reassigned controllable<let>(let-bind-to-undefined,let-bind-stateful-upstream-alias) drop the dead handler from their resume payload.Generated by Claude Code