Skip to content

marked v18 #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UziTech merged 1 commit into from
Apr 7, 2026
Merged

marked v18 #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@markedjs/testutils",
"version": "17.0.5-0",
"version": "18.0.0-0",
"description": "Test utilities for marked and marked extensions",
"main": "lib/index.js",
"types": "lib/index.d.ts",
Comment on lines 1 to 6
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

marked v18 requires Node.js >= 20. It is recommended to add an engines field to package.json to reflect this requirement and ensure compatibility with the updated dependency.

{
  "name": "@markedjs/testutils",
  "version": "18.0.0-0",
  "description": "Test utilities for marked and marked extensions",
  "engines": {
    "node": ">= 20"
  },
  "main": "lib/index.js",
  "types": "lib/index.d.ts",

Expand Down Expand Up @@ -36,8 +36,8 @@
"dependencies": {
"@markedjs/html-differ": "^5.0.4",
"front-matter": "^4.0.2",
"marked": "17.0.6",
"marked-repo": "https://github.com/markedjs/marked/tarball/v17.0.1"
"marked": "18.0.0",
"marked-repo": "https://github.com/markedjs/marked/tarball/v18.0.0"
Comment on lines +39 to +40
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The upgrade to marked v18 introduces breaking changes regarding removed options. The pedantic and silent options have been removed (in v12 and v11 respectively) and are now ignored. The codebase in src/run-tests.ts still uses these options; specifically, the "Original" spec tests (line 133) rely on pedantic: true to simulate legacy behavior, which will no longer work. These tests should be updated to use appropriate extensions or alternative configurations.

},
"devDependencies": {
"@arethetypeswrong/cli": "^0.18.2",
Expand Down