Skip to content

Conversation

@dominik-korsa
Copy link
Contributor

@dominik-korsa dominik-korsa commented Oct 16, 2025

Fixes #675.

The reverted change was introduced in #627.

Please note that just as #627, this is a breaking change, but it might be acceptable, as raising an exception should not make existing code incorrect.

@dominik-korsa dominik-korsa force-pushed the hotfix/group-not-found branch from de216a2 to 2d90827 Compare October 16, 2025 12:58
Copy link
Collaborator

@ryshoooo ryshoooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @dominik-korsa and co for bringing this back up. I believe all your points are valid, especially for consistency across the library, does not make sense for one method not to raise GET exception while others do.

Twice now we have changed the behavior of this function in a breaking manner without actually doing a major version patch. Which sucks. I do not feel like doing it for the 3rd time. I'm happy with the changes here, but I'd like to release this as a breaking change. I do understand that this is technically not breaking as it has been released already, but those releases were unforeseen with a breaking change. Had I spotted the breakage, it'd have been released as such.

Would that be agreeable?

@dominik-korsa
Copy link
Contributor Author

Sure, I also think bumping the major version with this change is the correct way to go. Thanks for the detailed response btw!

@ryshoooo ryshoooo merged commit 60e9927 into marcospereirampj:master Dec 28, 2025
34 checks passed
@dominik-korsa dominik-korsa deleted the hotfix/group-not-found branch December 29, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KeycloakAdmin.get_group_by_path DOES NOT raise an exception when the group was not found

2 participants