Skip to content

Conversation

@SquallHalle
Copy link

Hey,
i wanted to share the videos directly with friends.
since i use a proxy i ip block everything except the new /public path and removed the need for the auth token for this path.
i added a share button to downloadcard but also to the filebrowser.
this fullfills my basic needs.

i think a next step would be to add a flag in the db if a file is public and also check for this but maybe on another day.

feedback welcome.

@marcopiovanello
Copy link
Owner

LGTM but the labels should be internationalized to be merged in master

@SquallHalle
Copy link
Author

i have added a player too.
"LGTM but the labels should be internationalized to be merged in master" - got it will check it.

@SquallHalle
Copy link
Author

@marcopiovanello i assume you talked about this {/* ← Das hier neu */} and not that i should add translation for all buttons right ? since other parts of the DownloadCard and FileBrowser are also not translated. could you clarify ? For the part i mentioned i added a commit to remove it.

@SquallHalle
Copy link
Author

meh. found an issue i was not accounting for

so the first share part works fine, but of course just delivers the media file.
I was thinking, that adding the player is a nice addition but this actually breaks the fix for what i try to solve.
i want an proxy use an ip-allowlist for / but allow all ips for /public but if i now offer a player on /#/public of course the code for an SPA is in / so it will be "forbidden".

so either i remove the player again or i would need to put the page in is whole public.
i removed the player commit agian, that was sloppy, sorry for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants