feat(server): generate the REST using the OpenAPI spec #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NefixEstrada
force-pushed
the
use-ogen
branch
2 times, most recently
from
f81e95b to
0df5768
Compare
With this change, the REST server is now generated based on the OpenAPI spec. This ties up both the definition and the implementation, preventing further deviations and invalid specifications (if it's invalid, it will fail to generate or won't be able to be used inside the server). With this, we can ensure that the OpenAPI consumers will always have the correct definition
NefixEstrada
force-pushed
the
use-ogen
branch
from
0df5768 to
d06c158
Compare
Owner
|
Hello @NefixEstrada, Thanks for your work and this PR! I need to think about this PR because it would be coherent with the open-API spec, but in the other hand I loose all the control on the code. |
Contributor
Author
|
Sure, no problem! It's only the transport / validation layer, though. If you want, I also could make a PR with only the schema updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the REST server is now generated based on the OpenAPI
spec. This ties up both the definition and the implementation,
preventing further deviations and invalid specifications (if it's
invalid, it will fail to generate or won't be able to be used inside the
server).
With this, we can ensure that the OpenAPI consumers will always have the
correct definition