Skip to content

Remember last selected song in song select#126

Open
flustix wants to merge 2 commits intomarchc1:devfrom
flustix:remember-selection
Open

Remember last selected song in song select#126
flustix wants to merge 2 commits intomarchc1:devfrom
flustix:remember-selection

Conversation

@flustix
Copy link
Contributor

@flustix flustix commented Mar 7, 2026

No description provided.

Copy link
Owner

@marchc1 marchc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChartSong was meant to be an abstraction, and adding an Id property to it directly attached to MuseDashSong is not the move IMO.

If this could be done differently, that would be ideal. I will look into ideas for this.

@flustix
Copy link
Contributor Author

flustix commented Mar 7, 2026

Could probably also assign the ID on custom charts and make it by filename. There just wasn't anything to differentiate charts after restarting.

@marchc1
Copy link
Owner

marchc1 commented Mar 7, 2026

Probably what would be best is if the song logic was separated similarly to how other descriptors are. In essence having a IChartProvider or something. Then you could be like "MuseDashChartProvider/ID HERE" maybe as the convar value. I'll think about the best way to do it.

The only question is how that would work for MDMC charts (probably it just shouldn't, and instead always start at the beginning)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants