Skip to content

Add deep clone for cluster mapping #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add deep clone for cluster mapping #216

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7874dee
Add deep clone for cluster mapping
mrkwanzaa Feb 27, 2023
8eb8abb
Merge branch 'main' into deep-clone
mrkwanzaa Jul 6, 2023
76d3461
Merge pull request #1 from mapbox/main
mrkwanzaa Jul 24, 2023
a57f8bc
Merge pull request #2 from mrkwanzaa/main
mrkwanzaa Jul 24, 2023
14375be
Switch to structuredClone for deep cloning
mrkwanzaa Jul 24, 2023
4d89244
Merge branch 'mapbox:main' into main
mrkwanzaa Aug 30, 2023
2caa0f9
Merge remote-tracking branch 'origin/main' into deep-clone
mrkwanzaa Aug 30, 2023
ba6b67a
Merge pull request #3 from mapbox/main
mrkwanzaa Aug 14, 2024
4662c8e
Merge branch 'main' into deep-clone
mrkwanzaa Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,11 +369,11 @@ export default class Supercluster {
_map(data, i, clone) {
if (data[i + OFFSET_NUM] > 1) {
const props = this.clusterProps[data[i + OFFSET_PROP]];
return clone ? Object.assign({}, props) : props;
return clone ? structuredClone(props) : props;
}
const original = this.points[data[i + OFFSET_ID]].properties;
const result = this.options.map(original);
return clone && result === original ? Object.assign({}, result) : result;
return clone && result === original ? structuredClone(result) : result;
}
}

Expand Down Expand Up @@ -423,3 +423,4 @@ function yLat(y) {
const y2 = (180 - y * 360) * Math.PI / 180;
return 360 * Math.atan(Math.exp(y2)) / Math.PI - 90;
}