Fix installer pre-check UI layout by using scrollable panel#740
Fix installer pre-check UI layout by using scrollable panel#740divyesh-git22 wants to merge 2 commits intomandiant:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
d74e1e3 to
79227e2
Compare
|
Thank you for the PR @divyesh-git22! I am testing the PR on Windows 10 and I did notice some issues that need to be addressed:
This is how I would expect it to look when fixed:
Your code (note there are no scroll wheels on the sides for lower resolutions): |
|
@divyesh-git22 I checked your code. Looks like your edits are on pre-install check window and not on the installation wizard that has the package selection, installation path, etc. configurations. |
|
Hii @emtuls and @PrajeetGuha, I sincerely apologize for the confusion and the broken UI in my previous commits. As I am new to the project, I misunderstood which window needed the scrollbar and accidentally broke the Pre-Install UI and internet check logic. I am currently reverting install.ps1 to its original state to fix these errors. Once the project is back to a working state, I will correctly apply the scrollable fix to the Package Selection window as originally requested in #737. Thank you for your patience and for the detailed feedback |
|
Hi @divyesh-git22! I see that you are making a bunch of commits which might be unnecessary. 🙂 Also, we prefer to only have 1 commit made per change (i.e., 1 commit for this PR) to keep a cleaner git history. Might I suggest one of the following to clean up the branch? Option 1: Start fresh (Deletes your current changes).
Option 2: Squash and Reset (Keeps your work, but cleans history)
|
2ffec68 to
5e8355a
Compare
|
Hii @emtuls, Thank you so much for your guidance and for helping me ! I sincerely apologize for the earlier confusion and any extra work it caused you, I appreciate your patience while I was learning the process. I have now followed Option 2 and squashed all changes into a single, clean commit. I also moved the fix to the correct Package Selection window as requested: Added a scrollbar to the categories panel. Adjusted the window size and moved the buttons (Install/Cancel) up to ensure they are visible on all screen resolutions. |







This PR refactors the Pre-Install Checks UI to use a scrollable Panel
instead of fixed positioning.
what this change does:
No installer logic was changed by myside