Skip to content

Fix installer pre-check UI layout by using scrollable panel#740

Open
divyesh-git22 wants to merge 2 commits intomandiant:mainfrom
divyesh-git22:fix/preinstall-ui-scroll
Open

Fix installer pre-check UI layout by using scrollable panel#740
divyesh-git22 wants to merge 2 commits intomandiant:mainfrom
divyesh-git22:fix/preinstall-ui-scroll

Conversation

@divyesh-git22
Copy link
Copy Markdown

This PR refactors the Pre-Install Checks UI to use a scrollable Panel
instead of fixed positioning.
what this change does:

  • Prevents UI overflow on smaller screens
  • Removes dependency on manual spacing
    No installer logic was changed by myside

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Dec 26, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@emtuls
Copy link
Copy Markdown
Member

emtuls commented Jan 5, 2026

Thank you for the PR @divyesh-git22!

I am testing the PR on Windows 10 and I did notice some issues that need to be addressed:

  1. The Pre-Install Checks window seems to be broken:
    Scroll wheels have been added to the sides, which is a great change! But unfortunately, some other things broke in the process:
  • The checkbox we had to ensure users have made a snapshot before continuing seems to be missing.
  • The Continue and Cancel boxes seem to be missing.
  • The True and False indicators next to each check also seem to be missing.

Your code:
image
image

This is how I would expect it to look when fixed:
image

  1. The internet connectivity checks seem to have been removed:

Before (original code):
image

After (your PR):
image

  1. The package selection window still doesn't include the scroll bars on the sides, which I believe was the main concern from Flare-VM Package Installation Windows UI Issue #737

Your code (note there are no scroll wheels on the sides for lower resolutions):
image

This is how I would expect it to look when fixed:
image

@emtuls emtuls self-requested a review January 5, 2026 22:08
@emtuls emtuls added the 🐛 bug Something isn't working label Jan 5, 2026
Copy link
Copy Markdown
Member

@emtuls emtuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment!

@PrajeetGuha
Copy link
Copy Markdown
Contributor

PrajeetGuha commented Jan 7, 2026

@divyesh-git22 I checked your code. Looks like your edits are on pre-install check window and not on the installation wizard that has the package selection, installation path, etc. configurations.
My issue is with the VM package selection window that overflows and prevents me to click the OK button at the bottom as stated by @emtuls .

@divyesh-git22
Copy link
Copy Markdown
Author

Hii @emtuls and @PrajeetGuha,

I sincerely apologize for the confusion and the broken UI in my previous commits. As I am new to the project, I misunderstood which window needed the scrollbar and accidentally broke the Pre-Install UI and internet check logic.

I am currently reverting install.ps1 to its original state to fix these errors. Once the project is back to a working state, I will correctly apply the scrollable fix to the Package Selection window as originally requested in #737.

Thank you for your patience and for the detailed feedback

@emtuls
Copy link
Copy Markdown
Member

emtuls commented Jan 7, 2026

Hi @divyesh-git22!

I see that you are making a bunch of commits which might be unnecessary. 🙂 Also, we prefer to only have 1 commit made per change (i.e., 1 commit for this PR) to keep a cleaner git history.

Might I suggest one of the following to clean up the branch?

Option 1: Start fresh (Deletes your current changes).
Use this to wipe the slate and re-apply your changes cleanly:

  • git reset --hard main
  • make your changes to the file
  • git add <file>
  • git commit -m "Clean, single commit message"
  • git push origin <your-branch-name> --force-with-lease

Option 2: Squash and Reset (Keeps your work, but cleans history)
Alternatively, this would revert you back to the main commit, keeping your changes, so that you can make a single commit:

  • git reset --soft main
  • git commit -m "Clean, single commit message"
  • git push origin <your-branch-name> --force-with-lease

@divyesh-git22 divyesh-git22 force-pushed the fix/preinstall-ui-scroll branch from 2ffec68 to 5e8355a Compare January 7, 2026 21:01
@divyesh-git22
Copy link
Copy Markdown
Author

Hii @emtuls,

Thank you so much for your guidance and for helping me ! I sincerely apologize for the earlier confusion and any extra work it caused you, I appreciate your patience while I was learning the process.

I have now followed Option 2 and squashed all changes into a single, clean commit. I also moved the fix to the correct Package Selection window as requested:

Added a scrollbar to the categories panel.

Adjusted the window size and moved the buttons (Install/Cancel) up to ensure they are visible on all screen resolutions.
The PR should be much cleaner and ready for your review now. Thank you again for all your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants