ida: show addresses for file level features in rulegen#3009
Open
vee1e wants to merge 6 commits intomandiant:masterfrom
Open
ida: show addresses for file level features in rulegen#3009vee1e wants to merge 6 commits intomandiant:masterfrom
vee1e wants to merge 6 commits intomandiant:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the capa IDA Pro plugin by introducing support for file-scope feature addresses, allowing them to be displayed as file:0x... in the rule generator tree. The changes include logic to resolve these file offsets to virtual addresses for navigation and updates to the filtering mechanism to handle the new address format safely. A review comment suggests a minor optimization in the address formatting logic to remove a redundant integer conversion.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes address handling for file-scope features in the IDA rule generator tree.
Closes #1523
FileOffsetAddressvalues now render as file:0x... in the rule generator Address column.Visuals (highlighted in yellow box)
Using
al-khaser_x86.exeChecklist
AI usage disclosure
OpenCode with
openai/gpt-5.3-codexto help draft and apply code updates.@devs6186's code in #2904 was also used as a reference.