Conversation
|
@mike-hunhoff & @mr-tz Can you please review it |
data-manipulation/compression/decompress-data-using-zlib-fast-inflate.yml
Outdated
Show resolved
Hide resolved
Signed-off-by: priyank <priyank8445@gmail.com>
13ca7df to
ea00ed6
Compare
|
@mike-hunhoff i removed the unnecesarry reference line |
|
@priyank766 rule_linter error: Please ensure all unit tests pass locally before requesting another review. |
|
@mike-hunhoff So sorry about jumping the gun on the review. I was actually trying to run the linter locally, but Windows Defender kept silently deleting the test sample from After digging into the assembly source, I finally saw my mistake: the "Fast decoding" string is just an unreferenced watermark in the binary, and the mask bytes are in an external data table. Since the rule is scoped to the function body, capa couldn't actually match them! I just pushed a new commit removing those two unreachable features, so the rule should perfectly match the function scope now. I'll make sure everything is completely green before asking for another review next time! |
Closes #494.
Adds a function-scope rule,
decompress data using ZLIB fast inflate, for Chris Anderson's x86 assembly implementation of zlibinflate_fast, based on the assembly implementation referenced in the issue.Validation:
scripts/capafmt.pyon the new rulecapa-testfilessample is not available as a readable file in my environmentReference: