debugger: more granular naming for symbol table types #13733
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address the naming feedback from b39e684. That commit added an enum to identify the type of each symbol table. This PR adds a few enum values so that symbol tables can be more granularly typed. With the PR, the list is:
This reduces the set of symbols confusingly identified as global. But the debugger's global symbol table is still named as such (for now) because that’s how the public symlist docs, preexisting function names, and code comments have been referring to it. If you’d like those changed, that’s totally fine, let me know what you’d like. A few candidates: DEBUGGER_GENERAL, DEBUGGER_COMMON, DEBUGGER_BUILTIN.