Skip to content

Bugfixes for Functions 'times' and 'or' in lang Package#21

Open
Darkfrobozz wants to merge 1 commit into
malyzajko:masterfrom
Darkfrobozz:master
Open

Bugfixes for Functions 'times' and 'or' in lang Package#21
Darkfrobozz wants to merge 1 commit into
malyzajko:masterfrom
Darkfrobozz:master

Conversation

@Darkfrobozz

@Darkfrobozz Darkfrobozz commented Jun 19, 2025

Copy link
Copy Markdown

This update fixes bugs in the lang package.

The optimisation over Times expressions ignores errors: commented out these cases.
The optimisation over Or expressions uses the wrong data structure to match against, which can cause a crash: changed data structure to Seq.

Test Results Before Changes

[info] Run completed in 4 minutes, 38 seconds.
[info] Total number of tests run: 126
[info] Suites: completed 4, aborted 2
[info] Tests: succeeded 126, failed 0, canceled 0, ignored 0, pending 0
[info] *** 2 SUITES ABORTED ***
[error] Error: Total 97, Failed 0, Errors 2, Passed 95
[error] Error during tests:
[error]         regression.AbsErrorAnalysisRegressionTest
[error]         regression.PowTransformerRegressionTest
[error] (Test / test) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 284 s (04:44), completed Jun 19, 2025 3:16:17 PM

Test Results After Changes

[info] ScalaTest
[info] Run completed in 4 minutes, 40 seconds.
[info] Total number of tests run: 126
[info] Suites: completed 4, aborted 2
[info] Tests: succeeded 126, failed 0, canceled 0, ignored 0, pending 0
[info] *** 2 SUITES ABORTED ***
[error] Error: Total 97, Failed 0, Errors 2, Passed 95
[error] Error during tests:
[error]         regression.AbsErrorAnalysisRegressionTest
[error]         regression.PowTransformerRegressionTest
[error] (Test / test) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 286 s (04:46), completed Jun 19, 2025 3:24:32 PM

@Darkfrobozz Darkfrobozz changed the title times and or bugfixes Bugfixes for functions Times and Or Jun 19, 2025
@Darkfrobozz Darkfrobozz changed the title Bugfixes for functions Times and Or Bugfixes for Functions 'times' and 'or' in lang Package Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant