-
Notifications
You must be signed in to change notification settings - Fork 18
feat: add source parameter support to query execution endpoints #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
quirkyllama
wants to merge
11
commits into
main
Choose a base branch
from
jjs/implicit_parameters
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
74f0ff5
feat: add source parameter support to query execution endpoints
quirkyllama 7171a62
fix: change sourceParameters type from Record<string, string> to Reco…
quirkyllama 6586e76
style: fix eslint/prettier formatting in source_params files
quirkyllama 615380d
fix: silently ignore unknown source parameters instead of throwing
quirkyllama fe83a74
DCO Remediation Commit for Josh Sacks <josh.sacks@gmail.com>
quirkyllama a4818b9
fix: allow notebooks with parameterized sources to load without errors
quirkyllama 55c7464
feat: compile parameterized notebook cells with stub values at load time
quirkyllama a4ccf42
fix: resolve typecheck errors in notebook params test
quirkyllama ce347c7
fix: inject source parameters into raw query path too
quirkyllama 636fdc5
test: add integration tests for getQueryResults with source parameters
quirkyllama ba8655f
DCO Remediation Commit for Josh Sacks <josh.sacks@gmail.com>
quirkyllama File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # Repository Notes | ||
|
|
||
| ## DCO (Developer Certificate of Origin) | ||
|
|
||
| This repository requires DCO sign-off on all commits. Do **not** create commits unless you can sign them (i.e. use `git commit -s` or `--signoff`). Unsigned commits will be rejected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought you were getting rid of this version of execute query.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to, but didn't think this PR was the right place. Happy to do this in another change though