Refactor getConnectionTableSource into BigQuery-specific and controll…#656
Merged
kylenesbit merged 4 commits intomainfrom Apr 5, 2026
Merged
Conversation
added 4 commits
April 4, 2026 22:31
…er-private methods - Inline fetchTableSchema into listTablesForBigQuery since BigQuery is the only listTables variant that needs individual schema fetches - Move getConnectionTableSource logic to a private fetchTable method on ConnectionController for the getTable endpoint - Remove deprecated /tableSource endpoint from server.ts - Remove deprecated /queryData GET endpoint from server.ts - Remove deprecated TableSource schema reference from api-doc.yaml - Add comprehensive unit tests for getSchemasForConnection, error handling edge cases, DuckLake schema prefixing, and extractErrorDataFromError - Fix TS strict null errors in ducklake.test.ts and db_utils.spec.ts Made-with: Cursor
Derive columns directly from source.fields instead of validating and mapping separately. The null source check is sufficient. Made-with: Cursor
Made-with: Cursor
I, Kyle Nesbit <kjnesbit@ms2.co>, hereby add my Signed-off-by to this commit: 6091b0f I, Kyle Nesbit <kjnesbit@ms2.co>, hereby add my Signed-off-by to this commit: 6471192 I, Kyle Nesbit <kjnesbit@ms2.co>, hereby add my Signed-off-by to this commit: 93600c5 Signed-off-by: Kyle Nesbit <kjnesbit@ms2.co> Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…er-private methods
Made-with: Cursor