Improve sidebar navigation, TOC structure, and doc cleanup#302
Open
jswir wants to merge 2 commits intomalloydata:mainfrom
Open
Improve sidebar navigation, TOC structure, and doc cleanup#302jswir wants to merge 2 commits intomalloydata:mainfrom
jswir wants to merge 2 commits intomalloydata:mainfrom
Conversation
- Default sidebar sections to collapsed, auto-expand active page's ancestor chain, persist state in sessionStorage (resets on tab close) - Fix section ID generation to handle multi-word names with special chars - Group Language Reference into subsections: Core Concepts, Data & Types, Expressions & Functions, Aggregation & Analysis, Composition - Add 13 missing pages to TOC that were linked but not in sidebar nav - Restyle nested sidebar sections with left border instead of gray boxes - Make active sidebar item visually distinct from hover state - Remove empty window.malloynb (moved to GA as calculations_windows) - Fix broken link in experiments.malloynb to point to calculations_windows - Add experimental flag callout to sql_expressions docs Signed-off-by: James Swirhun <james@credibledata.com>
Remove 5 pages from TOC after audit against Malloy codebase: - basic.malloynb: duplicated by querying_a_model + quickstart_modeling - apply.malloynb: duplicated by expressions.malloynb Application section - new_functions.malloynb: historical v0.0.39 changelog, covered in functions.malloynb - sql_blocks.malloynb: superseded by sql_sources.malloynb - apijson.malloynb: all code commented out, non-functional Update inbound links: - index.malloynb: Quickstart link now points to querying_a_model - datatypes.malloynb: apply operator links point to expressions - time-ranges.malloynb: apply operator links point to expressions - connections.malloynb: remove broken apijson example link Signed-off-by: James Swirhun <james@credibledata.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replace(" ", "_")only replaced first space, breaking sessionStorage persistencewindow.malloynb— feature moved to GA ascalculations_windowsTest plan
/documentation/experiments/sql_expressionsrenders correctlynpm run build)