Support Bevy 0.19 - #119
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This turned out to mainly be updating the EGUI side of things due to bevy_egui bumping the version.
I bumped this crate's version to 0.18.0. Feel free to remove that change or change it to something else of course; I'm not sure what system you're using.
EGUI changes
The EGUI changes mostly follow the various struct and method renaming in EGUI 0.34 and 0.35.
Bevy Changes
On the Bevy side of things, I have a couple of notes:
SystemParam::get_param()
SystemParam::get_param()now returns a Result. I didn't make much use of it beyond bubbling up the inner calls toget_param(), though the find_map loop could bubble up its errors now instead. That would result in a change of behavior, so I didn't do that.Commands deriving Resource
Commands previously derived Resource, though
#[derive(Resource)]now performs component registration internally, which can't be reproduced without actually adding the derive to every command. However, it also appears that commands didn't need to deriveResourceanyway, justSend + Sync + 'staticto work with SystemParams. As such, I just removed the old manual impl Resource.Testing
I ran all 6 examples on Windows; they appear to still function as they did before. If someone wants to test Linux, feel free; I don't currently have a WSL instance on my machine.