chore(deps): upgrade Storybook to v10 and fix security advisories#9277
Conversation
Storybook upgrade (latest 10.4.6): - Align catalog so storybook + all @storybook/* are lockstep on 10.4.6 - addon-designs 11.1.3, addon-styling-webpack 3.0.2, addon-webpack5-compiler-swc 4.0.3, @chromatic-com/storybook 5.2.1 - Remove discontinued packages (addon-essentials, addon-interactions, blocks, test); add @storybook/addon-docs to packages/ui - Fix .storybook/main.ts ESM loading via createRequire(import.meta.url) - Revert propel's hardcoded storybook version back to catalog: Security advisories: - undici 7.24.0 -> 7.28.0 (7 CVEs incl. GHSA-vmh5-mc38-953g) - @opentelemetry/core|resources|sdk-trace-base -> 2.8.0 (GHSA-8988-4f7v-96qf) Also includes bundled dependency bumps already pending on the branch (vite 8, postcss, babel, markdown-it, ws, form-data, etc.).
📝 WalkthroughWalkthroughStorybook is upgraded from v9 to v10.4.6 across the workspace catalog. Both Storybook config files gain ESM-compatible ChangesStorybook v10 Upgrade and ESM Compatibility
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…cope + workspace-name валидация + Storybook v10) upstream makeplane#9269/makeplane#9270 (scope issue-ID/cascade-delete к workspace в bulk-эндпоинтах), makeplane#9263/makeplane#9278 (workspace name ≥1 буквенно-цифровой), makeplane#9277 (Storybook v10). Конфликт sub_issue.py разрешён объединением: eyriehq validate_sub_issues_bulk + upstream workspace__slug-scope. Наш GraphQL-шлюз уже безопасен (мутации ре-парента scope по project=p), поддержка не нужна. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Description
Dependency maintenance PR with two main goals:
1. Upgrade Storybook to the latest stable (v10.4.6)
The catalog was previously split-brained —
storybookwas on9.1.19while several@storybook/*addons had already been bumped to10.4.6, which forcedpackages/propelto hardcode itsstorybookversion and left two copies in the lockfile. This PR fully aligns the upgrade:storybook+ all core@storybook/*packages are now lockstep on 10.4.6 in thecatalog:block.@storybook/addon-designs→ 11.1.3,@storybook/addon-styling-webpack→ 3.0.2,@storybook/addon-webpack5-compiler-swc→ 4.0.3,@chromatic-com/storybook→ 5.2.1.@storybook/addon-essentials,@storybook/addon-interactions,@storybook/blocks,@storybook/test); their features are now built into core. Added@storybook/addon-docstopackages/uito preserve the Docs tab thataddon-essentialsused to provide..storybook/main.tsfiles: Storybook 10 loads them as native ESM, so therequire.resolve-basedgetAbsolutePathhelper now usescreateRequire(import.meta.url).packages/propel's hardcoded"storybook": "10.4.6"back to"catalog:".2. Fix open security advisories
undici7.24.0→ 7.28.0 (resolves 7 advisories incl. high-severity GHSA-vmh5-mc38-953g, GHSA-hm92-r4w5-c3mj, GHSA-vxpw-j846-p89q). It was pinned to the exact vulnerable version inoverrides:.@opentelemetry/core/resources/sdk-trace-base→ 2.8.0 (GHSA-8988-4f7v-96qf). Bumped as a lockstep trio because the siblings pincoreto an exact version.This PR also carries dependency bumps that were already pending on the branch (vite 8, postcss, babel, markdown-it, ws,
form-data, plus the newminimumReleaseAgeExcludeblock), since the regeneratedpnpm-lock.yamlcan't be cleanly split.Type of Change
Screenshots and Media (if applicable)
Test Scenarios
pnpm installresolves cleanly;pnpm peers checkreports no new storybook/chromatic peer issues.pnpm audit→ No known vulnerabilities found.pnpm --filter @plane/propel build-storybook→ builds successfully (react-vite).pnpm --filter @plane/ui build-storybook→ builds successfully (react-webpack5). Note: requires the generatedpackages/ui/styles/output.css(run the package'spostcssscript first).pnpm --filter @plane/propel storybook/pnpm --filter @plane/ui storybookand confirm stories and the Docs tab render.storybook@10.4.6copy,undici@7.28.0,@opentelemetry/*@2.8.0, and zero discontinued@storybook/*packages remaining.References