fix(typescript-config): include react-router.json in published files#9276
fix(typescript-config): include react-router.json in published files#9276gentslava wants to merge 1 commit into
Conversation
The `react-router.json` preset exists in the package and is consumed by apps/web, apps/admin and apps/space via `extends`, but it is missing from the `files` array in package.json — only the other four presets are listed. This makes the package manifest inconsistent with its contents: the preset would be dropped on `npm pack`/publish, and stricter `extends` resolvers (including the VS Code TS language server) report `Cannot find base config file "@plane/typescript-config/react-router.json"`. Add `react-router.json` to `files` so the manifest matches the directory. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesTypeScript Config Package Publish List
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Backport of upstream PR makeplane#9276. The react-router.json preset is consumed by apps/web, apps/admin and apps/space via `extends` but was missing from the `files` array; add it so the manifest matches the package contents and stricter `extends` resolvers (incl. the VS Code TS server) stop reporting the missing base config. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Description
The
react-router.jsonTypeScript config preset exists inpackages/typescript-config/and is referenced byapps/web,apps/adminandapps/spacevia"extends": "@plane/typescript-config/react-router.json". However it is missing from thefilesarray in the package'spackage.json, which lists only the other four presets (base.json,nextjs.json,react-library.json,node-library.json).The manifest therefore does not match the package contents:
npm pack/ publish output;extendsresolvers — including the VS Code TypeScript language server — fail to resolve it and reportCannot find base config file "@plane/typescript-config/react-router.json".This PR adds
react-router.jsontofilesso the manifest matches the directory. One-line, non-breaking; no change to compiler behavior.Type of Change
Screenshots and Media (if applicable)
N/A — manifest-only change.
Test Scenarios
npm pack --dry-runinpackages/typescript-confignow includesreact-router.jsonin the tarball (previously omitted).tsc -p apps/web/tsconfig.json --showConfigresolves theextendschain without errors.References
N/A
Summary by CodeRabbit