Skip to content

fix(typescript-config): include react-router.json in published files#9276

Open
gentslava wants to merge 1 commit into
makeplane:previewfrom
gentslava:fix/typescript-config-react-router-files
Open

fix(typescript-config): include react-router.json in published files#9276
gentslava wants to merge 1 commit into
makeplane:previewfrom
gentslava:fix/typescript-config-react-router-files

Conversation

@gentslava

@gentslava gentslava commented Jun 20, 2026

Copy link
Copy Markdown

Description

The react-router.json TypeScript config preset exists in packages/typescript-config/ and is referenced by apps/web, apps/admin and apps/space via "extends": "@plane/typescript-config/react-router.json". However it is missing from the files array in the package's package.json, which lists only the other four presets (base.json, nextjs.json, react-library.json, node-library.json).

The manifest therefore does not match the package contents:

  • the preset is excluded from npm pack / publish output;
  • stricter extends resolvers — including the VS Code TypeScript language server — fail to resolve it and report Cannot find base config file "@plane/typescript-config/react-router.json".

This PR adds react-router.json to files so the manifest matches the directory. One-line, non-breaking; no change to compiler behavior.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots and Media (if applicable)

N/A — manifest-only change.

Test Scenarios

  • npm pack --dry-run in packages/typescript-config now includes react-router.json in the tarball (previously omitted).
  • tsc -p apps/web/tsconfig.json --showConfig resolves the extends chain without errors.

References

N/A

Summary by CodeRabbit

  • Chores
    • Updated package distribution to include React Router TypeScript configuration file alongside other exported TypeScript configs.

The `react-router.json` preset exists in the package and is consumed by
apps/web, apps/admin and apps/space via `extends`, but it is missing from
the `files` array in package.json — only the other four presets are listed.

This makes the package manifest inconsistent with its contents: the preset
would be dropped on `npm pack`/publish, and stricter `extends` resolvers
(including the VS Code TS language server) report
`Cannot find base config file "@plane/typescript-config/react-router.json"`.

Add `react-router.json` to `files` so the manifest matches the directory.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a99df7e3-eb8c-4df6-844f-0ef26547db94

📥 Commits

Reviewing files that changed from the base of the PR and between 53a323d and 1652422.

📒 Files selected for processing (1)
  • packages/typescript-config/package.json

📝 Walkthrough

Walkthrough

packages/typescript-config/package.json is updated to add react-router.json to the files array, ensuring it is included in the published npm package alongside the existing TypeScript config JSON files.

Changes

TypeScript Config Package Publish List

Layer / File(s) Summary
Add react-router.json to published files
packages/typescript-config/package.json
react-router.json is appended to the files array so it is included when the package is published to npm.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops through configs wide,
and tucks react-router.json inside.
Published neat with the rest of the crew,
one tiny line, but the package is true!
🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding react-router.json to the published files list in the typescript-config package.
Description check ✅ Passed The description is comprehensive and well-structured, following the template with detailed context, type of change, test scenarios, and clear explanation of the issue and fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

gentslava added a commit to gentslava/plane that referenced this pull request Jun 20, 2026
Backport of upstream PR makeplane#9276. The react-router.json preset
is consumed by apps/web, apps/admin and apps/space via `extends` but was
missing from the `files` array; add it so the manifest matches the package
contents and stricter `extends` resolvers (incl. the VS Code TS server) stop
reporting the missing base config.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants