Skip to content

Rebase copilot/fix-xlsx-export-issue onto master#246

Closed
Copilot wants to merge 2 commits intomasterfrom
copilot/fix-xlsx-export-issue
Closed

Rebase copilot/fix-xlsx-export-issue onto master#246
Copilot wants to merge 2 commits intomasterfrom
copilot/fix-xlsx-export-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Oct 19, 2025

Rebased the XLSX export fix branch onto latest master (6dd28dfc).

Changes

  • Branch rebased from older base to current master HEAD
  • Preserves XLSX export compatibility fixes:
    • Default font injection for empty reports
    • Worksheet relationship entries for empty sheets
    • Consistent r:id references across workbook files

Verification

  • Build passes with no new errors
  • No merge conflicts during rebase
Original prompt

This section details on the original issue you should resolve

<issue_title>xlsx Export Issue again</issue_title>
<issue_description>If you open the exported xlsx with Excel 2013, it warns you that the file needs to be recovered.

In the contents of the xlsx file, I've noticed the following mistakes:

  • \xl\styles.xml: no font is defined
  • \xl\workbook.xml: r:id="rId1" is not correct
  • \xl_rels\workbook.xml: there is no Relationship entry for sheet1, specified in \xl\workbook.xml

See the attached empty report.
test_report.xlsx
</issue_description>

Comments on the Issue (you are @copilot in this section)

@majorsilence If you would like you can send a pull request with a fix.

https://github.com/majorsilence/My-FyiReporting/blob/master/RdlEngine/Render/ExcelValet.cs and https://github.com/majorsilence/My-FyiReporting/blob/master/RdlEngine/Render/RenderExcel.cs are probably the files you want to look into.</comment_new>

Fixes #161


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Fix xlsx export issue with recovery warning Fix XLSX export issues causing Excel 2013 recovery warnings Oct 19, 2025
Copilot AI requested a review from majorsilence October 19, 2025 19:49
Copilot AI changed the title Fix XLSX export issues causing Excel 2013 recovery warnings Rebase copilot/fix-xlsx-export-issue onto master Mar 14, 2026
@majorsilence majorsilence force-pushed the copilot/fix-xlsx-export-issue branch from a5ab0e4 to d45cf62 Compare March 14, 2026 18:52
Copilot AI and others added 2 commits March 14, 2026 16:23
- Add default font to styles.xml when no fonts are defined
- Add missing worksheet relationship entry in workbook.xml.rels for empty sheets
- Ensure r:id references match between workbook.xml and workbook.xml.rels

Co-authored-by: majorsilence <656288+majorsilence@users.noreply.github.com>
@majorsilence majorsilence force-pushed the copilot/fix-xlsx-export-issue branch from d45cf62 to 297cfe6 Compare March 14, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xlsx Export Issue again

2 participants