Split non-ML part into a new talon-core package #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
andersk
force-pushed
the
talon-core-split
branch
from
9140900 to
3ed431d
Compare
|
This is fantastic. Using the fork, but LGTM. |
|
Have this would be amazing. Any progress on merging this? |
andrewelkins
approved these changes
Sep 2, 2020
andersk
added a commit
to andersk/zulip
that referenced
this pull request
Mar 12, 2021
mailgun/talon#200 Signed-off-by: Anders Kaseorg <[email protected]>
timabbott
pushed a commit
to zulip/zulip
that referenced
this pull request
Mar 19, 2021
mailgun/talon#200 Signed-off-by: Anders Kaseorg <[email protected]>
Author
|
@horkhe Can you please comment on whether this approach is acceptable for upstream? Zulip has been stuck on our fork of Talon for six years due to this issue and we would very much like to unfork it. If this is acceptable, I’m happy to respin this for the current version. |
Signed-off-by: Anders Kaseorg <[email protected]>
The nonstandard `setup.py install --no-ml` option didn’t work correctly with pip. We could move the ML dependencies into an extra, but that approach was previously rejected (mailgun#121): extras can’t be enabled by default, so it could have been disruptive to existing users. Instead, we split off a new talon-core package with no ML dependencies, and have talon re-export everything from it. Fixes mailgun#130; fixes mailgun#131. Signed-off-by: Anders Kaseorg <[email protected]>
andersk
force-pushed
the
talon-core-split
branch
from
3ed431d to
137ea31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nonstandard
setup.py install --no-mloption didn’t work correctly with pip. We could move the ML dependencies into an extra, but that approach was previously rejected (#121): extras can’t be enabled by default, so it could have been disruptive to existing users. Instead, we split off a new talon-core package with no ML dependencies, and have talon re-export everything from it.Fixes #130; fixes #131.