Open
Conversation
dirvine
reviewed
Feb 13, 2022
Member
|
We tend to be explicit. If you don't mind can you import the whole Entry type and we are good to go. sorry, but we are pushing consistency. It's a niggle and I apologize. We can get this in today if that's OK. |
dirvine
previously approved these changes
Feb 13, 2022
Member
dirvine
left a comment
dirvine
left a comment
There was a problem hiding this comment.
LGTM Thanks very much for the effort and me being pedantic. Great stuff
Author
|
Hi! Is it possible to merge this? Fixed clippy warnings just in case (though they are not related to this commit) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases you want to filter all cache entries with some function, so maybe this impl will help do it more optimally