Simplifies mypy type checking #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the mypy workflow to run type checking on the entire `ytdl_inline_bot` directory, instead of iterating over each file individually. This reduces the verbosity of the workflow and streamlines the type checking process.
There was a problem hiding this comment.
Pull Request Overview
The workflow is updated to simplify type checking by running mypy against the entire ytdl_inline_bot directory instead of iterating over each file.
- Removed per-file loop for invoking mypy
- Replaced with a single directory-based mypy command
Comments suppressed due to low confidence (1)
.github/workflows/check_types.yml:44
- The echo command references
$filewhich is undefined after removing the loop; consider removing this line or updating it to a static message (e.g.,echo "Checking types in ytdl_inline_bot...").
echo "Checking types in $file..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the mypy workflow to run type checking on the entire
ytdl_inline_botdirectory, instead of iterating over each fileindividually. This reduces the verbosity of the workflow and streamlines
the type checking process.