Skip to content

Conversation

@magicxor
Copy link
Owner

No description provided.

@magicxor magicxor self-assigned this Nov 16, 2025
Copilot AI review requested due to automatic review settings November 16, 2025 13:39
Copilot finished reviewing on behalf of magicxor November 16, 2025 13:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies integration tests by extracting common setup logic into a reusable Seed method, reducing code duplication across test files.

  • Introduces ISeedResult, IAppFactorySeedResult, and SeedResult classes to encapsulate the seeding result
  • Refactors ThreadRepositoryTests, PostRepositoryTests, and BanRepositoryTests to use the new Seed method instead of duplicating setup code
  • Updates .editorconfig to include .slnx file extension for proper indentation

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Hikkaba.Tests.Integration/Models/SeedResult.cs Adds a new class to encapsulate the seeding result with scope and app factory
Hikkaba.Tests.Integration/Models/ISeedResult.cs Defines interface for seed result with disposable scope
Hikkaba.Tests.Integration/Models/IAppFactorySeedResult.cs Defines interface for seed result that includes app factory
Hikkaba.Tests.Integration/Tests/Repositories/ThreadRepositoryTests.cs Refactors tests to use the new Seed method, reducing code duplication
Hikkaba.Tests.Integration/Tests/Repositories/PostRepositoryTests.cs Refactors tests to use the new Seed method, reducing code duplication
Hikkaba.Tests.Integration/Tests/Repositories/BanRepositoryTests.cs Refactors tests to use the new Seed method, reducing code duplication
.editorconfig Adds .slnx to the list of file extensions requiring 2-space indentation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@magicxor magicxor merged commit f72b384 into master Nov 16, 2025
4 checks passed
@magicxor magicxor deleted the feature/refactor-tests branch November 16, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants