Updates to .NET 10 and package upgrades #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the target framework to .NET 10. Updates nuget package dependencies to their latest versions. NU1903 warnings are suppressed for now.
magicxor
added
dependencies
Updates the .NET SDK version used in the test workflow to target .NET 10.0, ensuring compatibility and access to the latest features and improvements.
Copilot finished reviewing on behalf of
magicxor
November 13, 2025 00:45
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the codebase by upgrading to .NET 10 and updating NuGet package dependencies to their latest versions. The major architectural change replaces ASP.NET Core's IUrlHelper with a custom ILinkBuilder abstraction that wraps LinkGenerator for better control over URL generation.
Key Changes
- Updates target framework from net9.0 to net10.0 across all projects
- Replaces
IUrlHelper/IUrlHelperFactorywith customILinkBuilderservice usingLinkGenerator - Updates 30+ NuGet packages to versions 10.0.0 or their latest releases
- Switches from
AddNLogtoAddNLogWebfor better ASP.NET Core integration
Reviewed Changes
Copilot reviewed 54 out of 54 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Directory.Packages.props | Updates all package versions to .NET 10 compatible versions; adds transitive dependency overrides for security |
| Directory.Build.props | Suppresses NU1903 warnings for known vulnerabilities |
| Hikkaba.Web/Services/Contracts/ILinkBuilder.cs | New interface replacing IUrlHelper with LinkGenerator-based approach |
| Hikkaba.Web/Services/Implementations/LinkBuilder.cs | Implementation wrapping LinkGenerator for URL generation |
| Hikkaba.Web/Services/Contracts/IUrlHelperFactoryWrapper.cs | Removed obsolete wrapper interface |
| Hikkaba.Web/Services/Implementations/UrlHelperFactoryWrapper.cs | Removed obsolete wrapper implementation |
| Hikkaba.Web/Utils/Url/PostUrlUtils.cs | Migrated to use ILinkBuilder with FragmentString for anchor links |
| Hikkaba.Web/Utils/Url/BanUrlUtils.cs | Migrated to use ILinkBuilder with FragmentString for anchor links |
| Hikkaba.Web/Utils/Url/ThreadUrlUtils.cs | Migrated to use ILinkBuilder for URL generation |
| Hikkaba.Web/Extensions/DependencyInjection.cs | Updated DI registration to use ILinkBuilder instead of IUrlHelper wrappers |
| Hikkaba.Web/Program.cs | Changed from AddNLog to AddNLogWeb for ASP.NET Core logging |
| Hikkaba.Web/Views/**/*.cshtml | Updated view templates to inject and use ILinkBuilder instead of Url helper |
| Hikkaba.Tests.Unit/Mocks/FakeLinkGenerator.cs | New mock implementation of LinkGenerator for testing |
| Hikkaba.Tests.Unit/Mocks/FakeHttpContextAccessor.cs | New mock for IHttpContextAccessor |
| Hikkaba.Tests.Unit/Mocks/FakeUrlHelper*.cs | Removed obsolete URL helper mocks |
| Hikkaba.Tests.Unit/CustomAppFactory.cs | Updated to register fake LinkGenerator and HttpContextAccessor |
| Hikkaba.Tests.Unit/Tests/Services/*.cs | Updated tests to work with new LinkGenerator-based approach |
| **/*.csproj | Updated all project files to target net10.0 framework |
| Various controller and service files | Removed unused using statements throughout codebase |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the target framework to .NET 10.
Updates nuget package dependencies to their latest versions.
NU1903 warnings are suppressed for now.