feat: choose sdk path#61
Conversation
WalkthroughThe pull request adds a ChangesVRF SDK path resolution
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@sdk/vrf-macro/src/lib.rs`:
- Around line 16-22: The vrf_sdk_path() proc-macro uses cfg!(feature =
"rollups") inside ephemeral-vrf-sdk-vrf-macro but the parent SDK crate does not
forward that feature, so consumers can't activate the rollups branch; fix by
adding a forwarding feature named "rollups" in the parent SDK crate's Cargo.toml
that maps to the proc-macro crate's feature (e.g., add a feature "rollups" =
["ephemeral-vrf-sdk-vrf-macro/rollups"]) and ensure the dependency entry for
ephemeral-vrf-sdk-vrf-macro is present so enabling sdk's "rollups" toggles the
macro crate's feature used by vrf_sdk_path().
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: aa5c3528-7e73-4841-8c13-ed09d6eb8c61
📒 Files selected for processing (2)
sdk/vrf-macro/Cargo.tomlsdk/vrf-macro/src/lib.rs
Adds a feature to select which VRF SDK to use, so that the macros reexported by the ephemeral_rollups_sdk work
Summary by CodeRabbit