Skip to content

Fix writable account failure logs #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GabrielePicco merged 2 commits into from
May 25, 2026
Merged

Fix writable account failure logs #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c258d0
fix writable account failure logs
GabrielePicco May 23, 2026
7dd00e6
chore: fix typo
GabrielePicco May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion svm/src/access_permissions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,12 @@ impl ExecutedTransaction {
self.execution_details.status = Err(TransactionError::InvalidWritableAccount);
let logs = self.execution_details.log_messages.get_or_insert_default();
logs.push(format!(
"Program log: Account {i}:{offender} was illegally used as writeable"
"Program log: Account {i}: {offender} was illegally used as writable"
));
logs.push(
"Program Magic11111111111111111111111111111111111111 failed: InvalidWritableAccount"
.to_string(),
);
Comment thread
GabrielePicco marked this conversation as resolved.
}
}
}
Expand Down Expand Up @@ -192,6 +196,16 @@ mod tests {
tx.execution_details.status,
Err(TransactionError::InvalidWritableAccount)
);
assert_eq!(
tx.execution_details.log_messages.as_ref().unwrap(),
&vec![
format!(
"Program log: Account 1: {writable} was illegally used as writable"
),
"Program Magic11111111111111111111111111111111111111 failed: InvalidWritableAccount"
.to_string(),
]
);
}

#[test]
Expand Down
Loading