Bugfix: DI is compiling#204
Merged
wpoortman merged 2 commits intomagewirephp:upgrade/hcfrom Mar 26, 2026
Merged
Conversation
JeroenBoersma
force-pushed
the
bugfix/di-compiling
branch
from
593f708 to
30cf4df
Compare
Contributor
Author
|
Checked the rebase on
This is obsolete as it doesn't exist anymore in the new branch, removed the commit. |
Contributor
Author
|
New errors arise in the new branch! |
JeroenBoersma
force-pushed
the
bugfix/di-compiling
branch
from
30cf4df to
9ba560e
Compare
Contributor
Author
This is also not needed anymore today! Which leaves us with one change, adding the |
+ this way they are registered as seperate libraries and are allowed in di.xml
JeroenBoersma
force-pushed
the
bugfix/di-compiling
branch
from
9ba560e to
9608e20
Compare
Contributor
Author
|
It is even simpler, I register the whole library for Magento! |
wpoortman
added a commit
that referenced
this pull request
Apr 23, 2026
* Feature/notifier styling (#199) * Remove redundent view instructions feature * Feature/notifier styling (#202) * Magewire Notification Component updates * Remove Redundant class * Improved notifiers * Remove close button * List theme support * Move the notifier back to the left (#203) * First intent on Claude skills for Magewire * Removed install instructions * Bugfix: DI is compiling (#204) * Update Request.php for php 8.4 (#205) * Update MagewireCommand.php to add static return type (#206) * Update MagewireUpdateRoute.php (#209) * Notifier Template + Styling updates (#211) * Update README to remove styles installation section * Removed code section about styles and installation steps from README. * Updated supported themes section in README. --------- Co-authored-by: Willem Poortman <wp@hyva.io> Co-authored-by: Ryan Hissey <ryan@hyva.io> Co-authored-by: Jeroen Boersma <JeroenBoersma@users.noreply.github.com> Co-authored-by: Ryan Hissey <ryan@hissey.dev> Co-authored-by: Willem Poortman <git@wpoortman.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Worked on the
bin/magento setup:di:compileand it is working nowProcess
magewirephp/magewire:dev-mainlocallybin/magento setup:di:compileFixes
Several hurdles needed to be taken before we could speak of success.
Adding Missing Dependency
Loosely Couple HyvaThemes
In a world I cannot remember but that sometimes exists in the wild, HyvaThemes could not be installed. So, we need to create a loose dependency for the
SvgIconsclass.Remove a Wrong Class Reference
Found a reference on a naming convention class which was added by accident, removed it.
Composer Autoloading
Composer autoloading with multiple
psr-4rules is working correctly. For Magento, every path that could be used fordi.xmlin compilation must be registered viaregistration.phpsrc/registration.phponly references as module and adds the../distdirectory for generated code.lib/Magewireandlib/MagewireBcwhere not part as library registration.registration.phpfor a library for both directories.Result
Compilation works correctly!
Anything Else
No, not per se, have fun with it!