Skip to content

V1: Add layout to fingerprint to enable layout-level Magewire components #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sparkable-agency wants to merge 2 commits into
base: 1.x
Choose a base branch
from
Open

V1: Add layout to fingerprint to enable layout-level Magewire components #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a29628
Update ComponentManager.php
sparkable-agency Mar 18, 2024
8e92245
Update Layout.php
sparkable-agency Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Model/Component/Resolver/Layout.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ public function construct(AbstractBlock $block): Component
public function reconstruct(RequestInterface $request): Component
{
$page = $this->resultPageFactory->create();
if ($request->getFingerprint('layout')) {
$page->getConfig()->setPageLayout(strtolower($request->getFingerprint('layout')));
}
$page->addHandle(strtolower($request->getFingerprint('handle')))->initLayout();

/**
Expand Down
7 changes: 6 additions & 1 deletion src/Model/ComponentManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use Magento\Framework\Exception\LocalizedException;
use Magento\Framework\Locale\Resolver;
use Magento\Framework\View\Element\Template;
use Magento\Framework\View\Page\Config;
use Magewirephp\Magewire\Exception\AcceptableException;
use Magewirephp\Magewire\Component;
use Magewirephp\Magewire\Exception\ComponentHydrationException;
Expand All @@ -21,19 +22,22 @@ class ComponentManager
{
protected Resolver $localeResolver;
protected HttpFactory $httpFactory;
protected Config $pageConfig;
protected array $updateActionsPool;
protected array $hydrationPool;

public function __construct(
HydratorContext $hydratorContext,
Resolver $localeResolver,
HttpFactory $httpFactory,
Config $pageConfig,
array $updateActionsPool = [],
array $hydrationPool = []
) {
$this->localeResolver = $localeResolver;
$this->updateActionsPool = $updateActionsPool;
$this->httpFactory = $httpFactory;
$this->pageConfig = $pageConfig;

// Core Hydrate & Dehydrate lifecycle sort order.
$this->hydrationPool = $this->sortHydrators($hydrationPool, [
Expand Down Expand Up @@ -153,7 +157,8 @@ public function createInitialRequest(

// Custom relative to Livewire's core.
'handle' => $handle ?? $request->getFullActionName(),
'type' => $component::COMPONENT_TYPE
'type' => $component::COMPONENT_TYPE,
'layout' => $this->pageConfig->getPageLayout()
],

'serverMemo' => [
Expand Down