V1: Adding symfony/http-kernel requirement#107
Open
callum-zero1 wants to merge 2 commits intomagewirephp:1.xfrom
Open
V1: Adding symfony/http-kernel requirement#107callum-zero1 wants to merge 2 commits intomagewirephp:1.xfrom
callum-zero1 wants to merge 2 commits intomagewirephp:1.xfrom
Conversation
Collaborator
|
How can we be sure this isn't gonna conflict elsewhere on a higher Magento version? I've been looking into #98 again. Maybe it's a better idea to try and get rid of any Not sure if it's possible, but if it's the only place where this is being used, it could be the better solution. |
Contributor
|
My 50 cents here: #135 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a requirement for the symfony/http-kernel package that isn't defined in the composer.json.
Example error:
I have removed the requirement of
symfony/http-foundationas this is now required bysymfony/http-kernel.I required version 4.4 because requiring 5.4 (matching the previously declared
symfony/http-foundationrequirement version) causes conflicts with other Symfony packages used by Magento 2.4.2.