Skip to content

[WHO] Implement Osgood, Operation Double #13744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

balazskristof
Copy link
Contributor

@github-actions github-actions bot added the cards label Jun 12, 2025
@JayDi85
Copy link
Member

JayDi85 commented Jun 12, 2025

For info: for new cards add comment ref to original set implementation issue like “Part of #10653”. So that PR will be visible in related links of the set’s issue.

Current scryfall bot do not support [[card name]] processing in title, first PR message or PR review, so I recommend to duplicate it as [[Osgood, Operation Double]] in new comment - so bot will add card description here.

Copy link

github-actions bot commented Jun 12, 2025

Osgood, Operation Double - (Gatherer) (Scryfall) (EDHREC)

{2}{U}{U}
Legendary Creature — Human Alien Shapeshifter
2/2
When you cast this spell, create a token that's a copy of it, except it isn't legendary.
{T}: Add {C}. Spend this mana only to cast an artifact spell or activate an ability of an artifact.
Paradox — Whenever you cast a spell from anywhere other than your hand, investigate. (Create a Clue token. It's an artifact with "{2}, Sacrifice this token: Draw a card.")

Copy link
Member

@JayDi85 JayDi85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Card logic is fine except few small fixes

@Override
public boolean apply(Game game, Ability source) {
MageObject object = game.getObject(source);
return object != null && object.isArtifact(game);
Copy link
Member

@JayDi85 JayDi85 Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you copy or fix code from another card with same ability/effect then must copy/fix all places with same code (even if you don’t understand the original logic). The main idea: same ability/effect must use same implementation code.

IMG_1543

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not touch this. Cargo Ship and other cards seem to work fine; I can use the mana to activate other activated abilities, like Unearth.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it’s about allow to activate one time only (activated sets true on activate call).

IMG_1547

I’m not sure why it used or required. Maybe for good playable calculations or some workaround from multiple instances, etc. But it’s better to keep same code.

@balazskristof balazskristof force-pushed the who-osgood-operation-double branch from b29311e to c2d717f Compare June 13, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants