[SLD] Implement The Fifteenth Doctor #13741
Conversation
| return controller.moveCards(card, Zone.HAND, source, game); | ||
| } | ||
| } | ||
| return false; |
There was a problem hiding this comment.
Must return true here cause milled in any use cases.
| if (controller.choose(outcome, cards, target, source, game)) { | ||
| Card card = game.getCard(target.getFirstTarget()); | ||
| if (card != null) { | ||
| return controller.moveCards(card, Zone.HAND, source, game); |
There was a problem hiding this comment.
Do not return here, see below return. Apply logic - return true id effect did anything to the game state and return false if it doesn’t (e.g. in wrong conditions or empty result).
| String message = "Put " + filter.getMessage() + | ||
| " from among the milled cards into your hand?"; | ||
| if (cards.isEmpty() | ||
| || !controller.chooseUse(outcome, message, source, game)) { |
There was a problem hiding this comment.
Use target 0, 1 with single dialog instead use + choose with two dialogs for better UX
|
|
||
| @Override | ||
| public boolean apply(ObjectSourcePlayer<Card> input, Game game) { | ||
| if (input.getObject() != null && !input.getObject().isArtifact(game)) { |
There was a problem hiding this comment.
No need in object filter in predicates. Player and object filled all the time. Same for source param (there are possible rare use cases with empty source but it not related to predicates).
| new GainAbilityControlledSpellsEffect(new ImproviseAbility(), filter) | ||
| .setText("The first nonartifact spell you cast each turn has improvise. " + | ||
| "<i>(Your artifacts can help cast that spell. Each artifact you " + | ||
| "tap after you’re done activating mana abilities pays for {1}.)")), |
There was a problem hiding this comment.
Error: (rules) card's rules contains restricted symbol ’ for SLD - The Fifteenth Doctor - 1584
Implements The Fifteenth Doctor