Skip to content

Fix saga first chapter zcc #13710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix saga first chapter zcc #13710

wants to merge 3 commits into from

Conversation

ssk97
Copy link
Contributor

@ssk97 ssk97 commented Jun 1, 2025

This is a cleaned version of #11619.

This makes it so that if a permanent is entering as the ability's zcc is being updated, then the zcc is the permanent's instead of the spell's. An ability that happens "as ~ enters" will not have a changed zcc, as it isn't put into the entering list until after those abilities have been processed. The new SigardasSplendorTest verifies this behavior.

This also centralizes the updating of ability zcc, though addDelayedTriggeredAbility is unchanged due to to d8959f1. The only logic change is in the getPermanentEntering check.

Fixes #11728

@xenohedron xenohedron requested a review from Susucre June 1, 2025 04:09
Copy link
Member

@JayDi85 JayDi85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xenohedron @Susucre do not merge until I finish the research (soon)

@Susucre
Copy link
Contributor

Susucre commented Jun 14, 2025

@JayDi85 have you gotten the time to review this?
It's been on alpha for 2 weeks, and no bug was noticed with it (commander, sealed and cube games occured)

@JayDi85
Copy link
Member

JayDi85 commented Jun 14, 2025

Yes, looks like it related to wrong usage of Ability::getSourceObjectZoneChangeCounter() and exile zone id (see details in #13737) -- I need to check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Battle at the Helvault Saga Chapter 1 does not exile despite a selection of valid targets
4 participants