Phase 1: Housekeeping + Configurable Attributes#52
Closed
DavidLambauer wants to merge 12 commits intomage-os-lab:mainfrom
Closed
Phase 1: Housekeeping + Configurable Attributes#52DavidLambauer wants to merge 12 commits intomage-os-lab:mainfrom
DavidLambauer wants to merge 12 commits intomage-os-lab:mainfrom
Conversation
Phased roadmap covering all 12 open issues: configurable attributes, multi-store/locale, prompt rules engine, review workflow, and structured attribute extraction.
Detailed task-by-task plan for housekeeping (mage-os-lab#22, mage-os-lab#23, mage-os-lab#25) and configurable attributes (mage-os-lab#27) with TDD steps, exact file paths, and code snippets.
This was referenced Apr 14, 2026
Contributor
Author
|
Closing in favor of @rhoerr's standalone PRs that cover the same issues with less bundling: #39 (#22), #38 (#25), #45 (#27). The only piece not covered by Ryan's stack is #23 (PSR-12 code style). I'll open a separate small PR for that on top of the merged baseline so it doesn't get held up by the bigger overlap. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
magento/framework,magento/module-catalog,magento/module-ui,magento/module-backend,magento/module-config,magento/module-store), removed mirror repository fromcomposer.jsonConfigurable Attributes (#27) Details
The static textarea fields for short_description, description, meta_title, meta_keyword, and meta_description have been replaced with a dynamic rows table in the admin config (Stores > Configuration > Catalog > AI Data Enrichment > Product Fields Auto-Generation).
Each row has:
{{variable}}supportChanges:
Block/Adminhtml/Form/Field/AttributeColumn— select renderer loading product text/textarea attributes viaProductAttributeRepositoryInterfaceBlock/Adminhtml/Form/Field/ProductAttributes— dynamic rows field array block extendingAbstractFieldArrayModel/Config— newgetEnrichableAttributes()method reads the serialized dynamic rows;getProductPrompt()delegates to itModel/Product/Enricher—getAttributes()now reads from config instead of returning a hardcoded arraySetup/Patch/Data/MigrateProductPromptsToDynamicRows— data patch migrating existing per-attribute config values to the new serialized format, then cleans up old pathsTest plan
setup:upgrade— should complete without errorssetup:di:compile— should complete without errors