Update ZipRepository.php to support password protected zip generation#17
Open
XPOL555 wants to merge 5 commits intomadnest:1.6from
Open
Update ZipRepository.php to support password protected zip generation#17XPOL555 wants to merge 5 commits intomadnest:1.6from
XPOL555 wants to merge 5 commits intomadnest:1.6from
Conversation
madnest#16 added public accessible methods setEncryptionName and setEncryptionIndex on ZipRepository.php
minor fixes, redundant null
Collaborator
|
Hello, I will look into that shortly. Also I have to fix PHP8 support for the whole thing. Will let you know. |
|
Hey @theimerj, hope you are doing well. It is posslbe to merge this request to have the password protection option? Tnx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#16 added public accessible methods
setEncryptionNameandsetEncryptionIndexonZipRepository.phpnote: idk if we should change also the RepositoryInterface... :/