Prevent podcast and episode details drawing under navigation bar#804
Closed
rudism wants to merge 1 commit intomadeofpendletonwool:mainfrom
Closed
Prevent podcast and episode details drawing under navigation bar#804rudism wants to merge 1 commit intomadeofpendletonwool:mainfrom
rudism wants to merge 1 commit intomadeofpendletonwool:mainfrom
Conversation
Author
|
I'll try to update this to remove all the formatting changes, I'm not sure what exactly I have installed that did that automatically. edit--OK it just has the SafeArea wrapper added now, no crazy reformatting of the files. |
rudism
force-pushed
the
mobile-safe-areas
branch
from
15fc00e to
9973526
Compare
Author
|
closing this in favor of #805 which includes these plus other enhancements/fixes for your consideration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mobile app's podcast and episode details pages were drawing underneath the navigation bar on Android (most noticeable when using 3-button navigation instead of gestures), causing either the last episode in the list or the mini player to be hidden. I wrapped those screens in SafeAreas here to fix that.