feat: Oscillation Handler#450
Merged
Merged
Conversation
…ware/MaCh3 into Feature/OscillatorHandler
…ware/MaCh3 into Feature/OscillatorHandler
…o Feature/OscillatorHandler
KSkwarczynski
requested review from
EdAtkin,
dbarrow257,
ewanwm and
henry-wallace-phys
as code owners
github-actions
Bot
added
Documentation 📚
|
Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this  Use this action on your projects. Use jokes on issues instead. |
Closed
dbarrow257
reviewed
May 14, 2025
dbarrow257
left a comment
dbarrow257
left a comment
Contributor
There was a problem hiding this comment.
I forget how passing vectors through functions work but doesn't OscParams go out of scope? (Too late on a Weds evening...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request description
First Merge:
#443
#443
#449
This PR creates OscillationHandler, which is simle wrapper around NuOscillator.
Similarly how we have spline handler etc.
Most of heavy lifting is still being done by NuOscillator but having seprate class allow to nicely detach parts of interface from SampelPDF.
To make it work one must merge: mach3-software/MaCh3Tutorial#123
Changes or fixes
Examples